Attention is currently required from: Arthur Heymans, Jon Murphy, Jérémy Compostella, Nico Huber, Werner Zeh.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81886?usp=email )
Change subject: arch/x86: Prevent .text/.init overlap with older linkers
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81886/comment/82e41dc9_76a79f98 :
PS2, Line 11: Default is 1024 bytes (1 KiB)
Do we have reasons for a new Kconfig switch here? Can't we just add this extra space hard for all, are there issues with this? Yes, it will enlarge the bootblock a bit, but do we have an issue in this regard at all?
Certainly, it is possible to expand the bootblock for all by adding 1KB, but do you require this increase? I had believed that, except for the ChromeOS builder, everyone had switched to a newer linker; hence, we are only dealing with size adjustments. We can remove this configuration after the ChromeOS builder is able to upgrade to the new linker.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81886?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I019bf6896d84b2a84dff6f22323f0f446c0740b5
Gerrit-Change-Number: 81886
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 15 Apr 2024 10:46:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment