Attention is currently required from: Alexander Couzens, Evgeny Zinoviev.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80437?usp=email )
Change subject: ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/lenovo/haswell/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/80437/comment/f7d94659_061a9912 :
PS1, Line 3: #define H8_HAS_LEDLOGO
It might be be better to implement this as a Kconfig and use something like `#if CONFIG(H8_HAS_LEDLOGO)` in `systemstatus.asl` instead of the `#if defined`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80437?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Gerrit-Change-Number: 80437
Gerrit-PatchSet: 1
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Sat, 10 Feb 2024 06:26:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment