Attention is currently required from: ChiaLing, Ryan Lin, Zhuohao Lee.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75678?usp=email )
Change subject: soc/intel/common: Add PsysPl1 support
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/power_limit.h:
https://review.coreboot.org/c/coreboot/+/75678/comment/41f5858e_8d1ab4fd :
PS2, Line 39: /* Minimum ROP */
: uint16_t min_rop;
This is not related to PsysPl1. Please move it to the CL where it's used.
Actually, let's get rid of the min_rop calculation for now. We can leave pl4 at the default of 60W for now and discuss more in the bug about how to set it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75678?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b2cf2c90ddef422c121e90edbe79dacb7e29320
Gerrit-Change-Number: 75678
Gerrit-PatchSet: 2
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Ryan Lin
ryan.lin@intel.com
Gerrit-Attention: ChiaLing
chia-ling.hou@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Tue, 13 Jun 2023 00:59:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Gerrit-MessageType: comment