Attention is currently required from: Henry Sun, Paul2 Huang.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59859 )
Change subject: mb/google/octopus/var/ampton: add touchscreen into SSFC support
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/octopus/variants/baseboard/include/baseboard/cbi_ssfc.h:
https://review.coreboot.org/c/coreboot/+/59859/comment/42a4f103_4a4ef45c
PS7, Line 44: SSFC_TOUCHSCREEN_ELAN9008,
Yes, ELAN9008 and ELAN0001 both are at same slave address (0x10)
* Could you have them with different i2c slave address by either FW or HW strap pin?
* Looks like ELAN0001 is in generic i2c driver but ELAN9008 is in hid over i2c so could you confirm kernel can not probe them correct and disable non-existed one?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59859
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0919d40a6c39ffaed52bb9e24a3509eb353127c
Gerrit-Change-Number: 59859
Gerrit-PatchSet: 8
Gerrit-Owner: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 07 Dec 2021 10:39:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Gerrit-MessageType: comment