Attention is currently required from: Arthur Heymans, Felix Held.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76495?usp=email )
Change subject: soc/amd/genoa: Add minimal viable code for compilation
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76495/comment/70293db2_a5342f28 :
PS7, Line 9: and mainboard (onyx)
Sorry - remove this?
Done
File src/soc/amd/genoa/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76495/comment/c48c0888_518a196b :
PS7, Line 1: ## SPDX-License-Identifier: GPL-2.0-only
If you wanted to, you could add a blank line after this, but it's not required.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76495?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69253466084d17c4359d7e824d69f12490b076e4
Gerrit-Change-Number: 76495
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 31 Aug 2023 19:06:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment