Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83991?usp=email )
Change subject: mb/lenovo/thinkcentre_m710s: Add SMBIOS data for PCIe slots ......................................................................
mb/lenovo/thinkcentre_m710s: Add SMBIOS data for PCIe slots
Change-Id: Iaa761108acbf275820ecbec9837b81bc5d64613e Signed-off-by: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83991 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de --- M src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb 1 file changed, 25 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Felix Singer: Looks good to me, approved
diff --git a/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb b/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb index f4f51b7..3eae806 100644 --- a/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb +++ b/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb @@ -5,6 +5,11 @@
device domain 0 on device ref peg0 on # PCIE16X + smbios_slot_desc "SlotTypePciExpressGen3X16" + "SlotLengthLong" + "PCIE16X" + "SlotDataBusWidth16X" + # These configurations are technically for PCIe root # ports. However, they are used as there is no # equivalent for PEG devices. @@ -58,6 +63,11 @@ register "PcieRpAdvancedErrorReporting[4]" = "true" end device ref pcie_rp7 on # PCIE1X_2 + smbios_slot_desc "SlotTypePciExpressGen3X1" + "SlotLengthShort" + "PCIE1X_2" + "SlotDataBusWidth1X" + register "PcieRpEnable[6]" = "true" register "PcieRpLtrEnable[6]" = "true" register "PcieRpClkReqSupport[6]" = "true" @@ -66,6 +76,11 @@ register "PcieRpAdvancedErrorReporting[6]" = "true" end device ref pcie_rp8 on # PCIE1X_1 + smbios_slot_desc "SlotTypePciExpressGen3X1" + "SlotLengthShort" + "PCIE1X_1" + "SlotDataBusWidth1X" + register "PcieRpEnable[7]" = "true" register "PcieRpLtrEnable[7]" = "true" register "PcieRpClkReqSupport[7]" = "true" @@ -74,6 +89,11 @@ register "PcieRpAdvancedErrorReporting[7]" = "true" end device ref pcie_rp11 on # M2_WIFI + smbios_slot_desc "SlotTypeM2Socket1_SD" + "SlotLengthOther" + "M2_WIFI" + "SlotDataBusWidth1X" + register "PcieRpEnable[10]" = "true" register "PcieRpLtrEnable[10]" = "true" register "PcieRpClkReqSupport[10]" = "true" @@ -82,6 +102,11 @@ register "PcieRpAdvancedErrorReporting[10]" = "true" end device ref pcie_rp21 on # M2_SSD + smbios_slot_desc "SlotTypeM2Socket3" + "SlotLengthOther" + "M2_SSD" + "SlotDataBusWidth1X" + register "PcieRpEnable[20]" = "true" register "PcieRpLtrEnable[20]" = "true" register "PcieRpClkReqSupport[20]" = "true"