13 Sep
2019
13 Sep
'19
4:44 a.m.
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35365 )
Change subject: emulation/qemu-i440fx: use fw_cfg_dma for fw_cfg_read ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35365/5/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/fw_cfg_if.h:
https://review.coreboot.org/c/coreboot/+/35365/5/src/mainboard/emulation/qem... PS5, Line 111: #define FW_CFG_VERSION_DMA 0x02
These lines are already being added.
My bad, typo. Thanks for pointing out! Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/35365
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0be5355b124af40aba62c0840790d46ed0fe80a2
Gerrit-Change-Number: 35365
Gerrit-PatchSet: 5
Gerrit-Owner: Name of user not set #1002476
Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Fri, 13 Sep 2019 11:44:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Idwer Vollering vidwer@gmail.com
Gerrit-MessageType: comment