Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44076 )
Change subject: soc/intel/common/block/cpu: Refactor init_cpus function ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44076/6/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/c/coreboot/+/44076/6/src/soc/intel/common/block/... PS6, Line 136: init_cpus
Just curious: Does this have to be done at a certain point after FSP-S init? I am thinking if it wou […]
yes can be done as well, bt wondering if user would like to run some multithreded programming immediately right after FSP-S return. in those case MP's won't be available if we are running using BS machine.
https://review.coreboot.org/c/coreboot/+/44076/6/src/soc/intel/common/block/... PS6, Line 149: : microcode_patch = intel_microcode_find(); : intel_microcode_load_unlocked(microcode_patch);
I know this change wasn't made here but since we are revisiting this path - how is microcode loading […]
valid point, FSP might not need to update ucode as we don't have SGX enable request bt if it does then there would be problem hence cb should provide ucode as part of UPD (MicrocodeRegionBase)