Attention is currently required from: Lance Zhao, Jason Glenesk, Martin Roth, Marshall Dawson, Kyösti Mälkki, Andrey Petrov, Patrick Rudolph, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49817 )
Change subject: ACPI: Add helpers for CBMEM_ID_POWER_STATE
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/acpi/acpi_pm.c:
https://review.coreboot.org/c/coreboot/+/49817/comment/296ae174_4f17a00c
PS5, Line 45: recorced
recor*d*ed
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/49817/comment/65a0ced0_0f6d2a1c
PS5, Line 55: struct chipset_power_state *pmc_get_power_state(void)
function is cursed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49817
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c5414a03d869423c8ae5192a990fde5f9582f2d
Gerrit-Change-Number: 49817
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 22 Jan 2021 12:30:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment