Attention is currently required from: Felix Singer, Filip Lewiński, Maciej Pijanowski, Martin L Roth, Michał Żygowski, Nicholas Chin.
Nico Huber has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83363?usp=email )
Change subject: payloads/ipxe/makefile: Use git reset for resetting config state
......................................................................
Patch Set 4:
(2 comments)
File payloads/external/iPXE/Makefile:
https://review.coreboot.org/c/coreboot/+/83363/comment/c6f079f3_e0ff14ea?usp... :
PS4, Line 35: config: checkout
`checkout` might already fail due to the dirty tree. So maybe move the cleanup there?
https://review.coreboot.org/c/coreboot/+/83363/comment/eb0a0182_d1c0f21c?usp... :
PS4, Line 37: git reset --hard
Why not
```
git -C $(project_dir) checkout -- src/config/console.h src/config/serial.h src/config/general.h
```
This would not undo unrelated changes, e.g. if somebody tries some code change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83363?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I325cf4d155780208b6f9cbbc49e50a69a4d59dd3
Gerrit-Change-Number: 83363
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Thu, 11 Jul 2024 14:06:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No