Sricharan Ramabadhran has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29954 )
Change subject: qcs405: Add DRAM resources
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/#/c/29954/13/src/soc/qualcomm/qcs405/include/soc...
File src/soc/qualcomm/qcs405/include/soc/symbols.h:
https://review.coreboot.org/#/c/29954/13/src/soc/qualcomm/qcs405/include/soc...
PS13, Line 29: extern u8 _dram_reserved[];
DECLARE_REGION as introduced in 7e0dea6317d
ok
https://review.coreboot.org/#/c/29954/13/src/soc/qualcomm/qcs405/soc.c
File src/soc/qualcomm/qcs405/soc.c:
https://review.coreboot.org/#/c/29954/13/src/soc/qualcomm/qcs405/soc.c@24
PS13, Line 24: ram_resource(dev, 0, (uintptr_t)_dram / KiB, DRAMSIZE1GB / KiB);
1 * GiB […]
ok, will fix
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29954
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea79a942c297400c88aa205da713bcfcb8c51185
Gerrit-Change-Number: 29954
Gerrit-PatchSet: 13
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Sricharan Ramabadhran
srichara@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Tue, 12 Mar 2019 13:29:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment