Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47311 )
Change subject: mb/google/zork: Power off fingerprint sensor on shutdown ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47311/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47311/3/src/mainboard/google/zork/v... PS3, Line 354: if (slp_typ == SLP_TYP_S5) {
No, there isn't a pulldown. […]
What do you think Furquan?
I agree with you that this patch isn't critical as everything will lose power on a shutdown eventually. Personally, I'm inclined to merge it since the fingerprint guys would like it, but if you'd still rather we didn't, I'm fine with that too.