Attention is currently required from: Henry Sun, Stanley Wu, Aseda Aboagye. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56858 )
Change subject: mb/google/dedede: add gooey variant ......................................................................
Patch Set 3:
(4 comments)
File src/mainboard/google/dedede/variants/gooey/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56858/comment/6c1445b1_5045458b PS3, Line 11: #| I2C5 | P-Sensor | Nit: Please fix the indentation.
https://review.coreboot.org/c/coreboot/+/56858/comment/b4b388be_0d4ae5ea PS3, Line 18: .scl_lcnt = 190, : .scl_hcnt = 100, : .sda_hold = 40, Coreboot recommendation is to configure rise_time_ns and fall_time_ns. I understand that it is copied from Boten. But prefer to fix it than copying and forgetting about it. Boten can be fixed in a follow-up CL.
https://review.coreboot.org/c/coreboot/+/56858/comment/cc8f7c75_be4c8dbe PS3, Line 68: register "SerialIoGSpiMode[PchSerialIoIndexGSPI0]" = "PchSerialIoDisabled" # Disable GSPI0 register "SerialIoGSpiCsMode[PchSerialIoIndexGSPI0]" = "0"
https://review.coreboot.org/c/coreboot/+/56858/comment/f925bfbc_134f62fe PS3, Line 334: end # PCH eSPI Disable GSPI 0