Attention is currently required from: Martin Roth, Jakub Czapiga, Paul Fagerburg, Julius Werner, Jan Dabros.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52159 )
Change subject: tests: Add lib/coreboot_table-test test case
......................................................................
Patch Set 2:
(1 comment)
File tests/lib/coreboot_table-test.c:
https://review.coreboot.org/c/coreboot/+/52159/comment/00dabaca_73a550cc
PS2, Line 329: test_write_tables
most of methods used by this function are static (so private) […]
I don't think the size is an issue here. It's just that this walks a data structure with _tons_ of different items and they all need handling.
Even if this was refactored into one test per item, we'd also need a test to check that there aren't any "unknown" fields in there, which will be pretty noisy again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52159
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d7d9ca43316bf514bb5ebd8909f441bcfa20eba
Gerrit-Change-Number: 52159
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Tue, 13 Apr 2021 16:13:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment