[coreboot-gerrit] [L] Change in coreboot[main]: mb/prodrive/atlas: Add initial support for options

[Lean Sheng Tan (Code Review)]

Attention is currently required from: Angel Pons, Kyösti Mälkki, Maximilian Brune, Patrick Rudolph.

Lean Sheng Tan has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/74122?usp=email )

Change subject: mb/prodrive/atlas: Add initial support for options
......................................................................

Patch Set 27:

(5 comments)

File src/mainboard/prodrive/atlas/cfr.c:

https://review.coreboot.org/c/coreboot/+/74122/comment/f320e25d_1e3e27e0?usp... :
PS7, Line 76: This option has no effect "
            : 				  "on systems without a RTC battery.
> We may want to suppress this option if we can tell from the profile that the carrier board does not  […]

Not sure how to do that..

File src/mainboard/prodrive/atlas/cfr.c:

https://review.coreboot.org/c/coreboot/+/74122/comment/aafb59db_6cf0e516?usp... :
PS18, Line 140:
> extra space

Done

https://review.coreboot.org/c/coreboot/+/74122/comment/4982101a_ea25773e?usp... :
PS18, Line 146:
> same

Done

https://review.coreboot.org/c/coreboot/+/74122/comment/418a8efb_5ff5e706?usp... :
PS18, Line 151:
> same

Done

File src/mainboard/prodrive/atlas/romstage_fsp_params.c:

https://review.coreboot.org/c/coreboot/+/74122/comment/c3ba29fe_d4ea52a6?usp... :
PS9, Line 57: mcfg->Ibecc = get_uint_option("ibecc", false);
            : 	mcfg->IbeccOperationMode = mcfg->Ibecc ? 2 : 0;
> There's a devicetree option that would need to be removed. […]

Acknowledged