Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38428 )
Change subject: soc/intel/{skylake,common}/acpi/dptf/thermal.asl: Prevent iasl remarks
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38428/1/src/soc/intel/skylake/acpi/...
File src/soc/intel/skylake/acpi/dptf/thermal.asl:
https://review.coreboot.org/c/coreboot/+/38428/1/src/soc/intel/skylake/acpi/...
PS1, Line 96: Store( Arg0, Local0)
Done
Done
https://review.coreboot.org/c/coreboot/+/38428/4/src/soc/intel/skylake/acpi/...
File src/soc/intel/skylake/acpi/dptf/thermal.asl:
https://review.coreboot.org/c/coreboot/+/38428/4/src/soc/intel/skylake/acpi/...
PS4, Line 89: #ifndef EC_ENABLE_MULTIPLE_DPTF_PROFILES
: /* Prevent iasl remarks about unused parameters */
: Store(Arg0, Local0)
: #endif
: Store(Arg1, Local0)
If I add this as well, it works. I will create an updated patch. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38428
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54fa4712e618038fdd5a96c2012c2ec64ca34706
Gerrit-Change-Number: 38428
Gerrit-PatchSet: 5
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 17 Jan 2020 09:34:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wim Vervoorn
wvervoorn@eltan.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment