Attention is currently required from: Karthik Ramasubramanian, Kun Liu, Shelley Chen, Subrata Banik.
Sumeet R Pawnikar has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83304?usp=email )
Change subject: mb/google/brox/var/lotso: Update DTT settings for thermal control
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83304/comment/48472bb5_17ef1232?usp... :
PS3, Line 9: 348285763
Add me in this bug to understand the current changes. Thanks.
File src/mainboard/google/brox/variants/lotso/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83304/comment/8d0604a4_9bbf2792?usp... :
PS3, Line 126: 12000
Please share the reason for changing this to lower value, ie. from 15W to 12W.
https://review.coreboot.org/c/coreboot/+/83304/comment/4a11b495_dd519962?usp... :
PS3, Line 134: 25000
Share details on lowering the PL2 Max and Min values from 55W to 25W.
Did you get chance to check the Benchmark/system performance with this change?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83304?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67e16a2596884d501273a5787119406dff7a20f9
Gerrit-Change-Number: 83304
Gerrit-PatchSet: 3
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dengwu Yu
yudengwu@huaqin.corp-partner.google.com
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 04 Jul 2024 10:25:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No