Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Reka Norman, Ivy Jian.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63568 )
Change subject: mb/google/nissa: Add gpio lock pins
......................................................................
Patch Set 3:
(4 comments)
Patchset:
PS3:
I will check this when I get the system build units. Here is issue, https://partnerissuetracker.corp.google.com/u/0/issues/229142661
File src/mainboard/google/brya/variants/baseboard/nissa/gpio.c:
https://review.coreboot.org/c/coreboot/+/63568/comment/431cebee_c680a505
PS3, Line 239: PAD_CFG_GPI_IRQ_WAKE_LOCK(GPP_F14, NONE, LEVEL, INVERT, LOCK_CONFIG),
haven't test that. […]
Done
https://review.coreboot.org/c/coreboot/+/63568/comment/3b3cecb3_d7a8e552
PS3, Line 241: PAD_CFG_GPI_SCI_HIGH_LOCK(GPP_F15, NONE, EDGE_SINGLE, LOCK_CONFIG),
I will test the wake event after P1 build :p WDYT? I only have MB without any keyparts hehe.
Done
https://review.coreboot.org/c/coreboot/+/63568/comment/df1b85ce_25f2cf20
PS3, Line 245: PAD_CFG_GPI_SCI_LOCK(GPP_F17, NONE, LEVEL, INVERT, LOCK_CONFIG),
EC should change? https://chromium-review.googlesource. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63568
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib34ca287596a6958407a944d0caf53f4bcc60d9b
Gerrit-Change-Number: 63568
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 14 Apr 2022 00:51:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment