Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31852 )
Change subject: mb/google/hatch: Set hatch to use SOC_INTEL_COMETLAKE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31852/1/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/31852/1/src/mainboard/google/hatch/Kconfig@1... PS1, Line 18: select SOC_INTEL_WHISKEYLAKE if BOARD_GOOGLE_HATCH_WHL : select SOC_INTEL_COMETLAKE if BOARD_GOOGLE_HATCH Let's just do this in Kconfig.name. That way we don't need to add "if BOARD..." here