[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake/acpi/dptf/thermal.asl: Prevent iasl remarks

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38428 )

Change subject: soc/intel/skylake/acpi/dptf/thermal.asl: Prevent iasl remarks
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38428/4/src/soc/intel/skylake/acpi/... 
File src/soc/intel/skylake/acpi/dptf/thermal.asl:

https://review.coreboot.org/c/coreboot/+/38428/4/src/soc/intel/skylake/acpi/... 
PS4, Line 89: #ifndef EC_ENABLE_MULTIPLE_DPTF_PROFILES
            : 	/* Prevent iasl remarks about unused parameters */
            : 	Store(Arg0, Local0)
            : #endif
            : 	Store(Arg1, Local0)
Would this work:

Change src/ec/google/chromeec/acpi/ec.asl so that Method RDCP is defined only if EC_ENABLE_MULTIPLE_DPTF_PROFILES is defined and then the check here can be simplified:

Method (DTRP, 2, Serialized)
{
    If (CondRefOf (_SB.PCI0.LPCB.EC0.RCDP)) {
         If (_SB.PCI0.LPCB.EC0.RCDP == One)
             Return (CTOK (Arg0))
    }

Return (CTOK (Arg1))
}

Just avoids the multiple stores to Local0 which seemed a little confusing.