[coreboot-gerrit] [M] Change in coreboot[master]: lenovo/x230: introduce FHD variant

[Name of user not set (Code Review)]

Attention is currently required from: Felix Singer, Xue Yao, Paul Menzel, Kilian Neuner, Angel Pons, Charles Moyes, Alexander Couzens.

[e-mail] has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )

Change subject: lenovo/x230: introduce FHD variant
......................................................................

Patch Set 22:

(1 comment)

Patchset:

PS22:
> For Heads, I cherry-picked commits for coreboot 4.13 (I know, old) […]

On top of 4.19, I had to modify patch obtained by

git fetch https://review.coreboot.org/coreboot refs/changes/50/28950/22 && git format-patch -1 --stdout FETCH_HEAD

Tested with coreboot config:
# CONFIG_USE_BLOBS is not set
CONFIG_VENDOR_LENOVO=y
CONFIG_NO_POST=y
CONFIG_ONBOARD_VGA_IS_PRIMARY=y
CONFIG_CBFS_SIZE=0xBE4FFF
CONFIG_INTEL_GMA_VBT_FILE="src/mainboard/$(MAINBOARDDIR)/variants/x230_edp/data.vbt"
CONFIG_IFD_BIN_PATH="@BLOB_DIR@/xx30/ifd.bin"
CONFIG_ME_BIN_PATH="@BLOB_DIR@/xx30/me.bin"
CONFIG_GBE_BIN_PATH="@BLOB_DIR@/xx30/gbe.bin"
CONFIG_HAVE_IFD_BIN=y
CONFIG_BOARD_LENOVO_X230_EDP=y
CONFIG_LINUX_COMMAND_LINE="intel_iommu=igfx_off quiet"
CONFIG_UART_PCI_ADDR=0
CONFIG_HAVE_ME_BIN=y
CONFIG_HAVE_GBE_BIN=y
CONFIG_DRIVERS_PS2_KEYBOARD=y
CONFIG_TPM_MEASURED_BOOT=y
CONFIG_CONSOLE_CBMEM_BUFFER_SIZE=0x80000
CONFIG_PAYLOAD_LINUX=y
CONFIG_PAYLOAD_FILE="@BOARD_BUILD_DIR@/bzImage"
CONFIG_LINUX_INITRD="@BOARD_BUILD_DIR@/initrd.cpio.xz"

Building at coreboot 4.13 -> 4.19 coreboot version bump at https://app.circleci.com/pipelines/github/tlaurion/heads/1452/workflows/fc66...

For WiP commit https://github.com/tlaurion/heads/commit/1112a58fe7841dcb93e2d8bf498f498d458... where

Modified patch successfully applying locally on top of 4.19 release at https://github.com/tlaurion/heads/commit/1112a58fe7841dcb93e2d8bf498f498d458...

Note override of CONFIG_INTEL_GMA_VBT_FILE above in config.