Attention is currently required from: Sean Rhodes.
Paul Menzel has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85693?usp=email )
Change subject: mb/starlabs/*: Declare all DDI interfaces ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85693/comment/9e1e7e85_98ca2b14?usp... : PS2, Line 8:
`'noticable' may be misspelled - perhaps 'noticeable'?`
Please fix.
https://review.coreboot.org/c/coreboot/+/85693/comment/0b2cab6d_734335e0?usp... : PS2, Line 12: How can this be tested? Some log line?
File src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85693/comment/745bbe18_3e0c7a5a?usp... : PS2, Line 22: [DDI_PORT_A] = DDI_ENABLE_HPD, Excuse my ignorance, how does this relate with the commit message? You remove `DDI_ENABLE_DDC`.