Eugene Myers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44686 )
Change subject: security/intel/stm: Add options for STM build ......................................................................
Patch Set 4:
(5 comments)
Updates are in patch set 4
https://review.coreboot.org/c/coreboot/+/44686/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44686/3//COMMIT_MSG@12 PS3, Line 12:
Tested how?
Text changed to indicate the conditions that the default settings assume.
https://review.coreboot.org/c/coreboot/+/44686/3/src/security/intel/stm/Kcon... File src/security/intel/stm/Kconfig:
https://review.coreboot.org/c/coreboot/+/44686/3/src/security/intel/stm/Kcon... PS3, Line 1:
Unrelated change.
Done
https://review.coreboot.org/c/coreboot/+/44686/3/src/security/intel/stm/Kcon... PS3, Line 33:
Isn’t it indented by two spaces?
Done
https://review.coreboot.org/c/coreboot/+/44686/3/src/security/intel/stm/Kcon... PS3, Line 37: To use STM/PE, a larger MSEG_SIZE is necessary. This can be
Please add a blank line above.
Done
https://review.coreboot.org/c/coreboot/+/44686/3/src/security/intel/stm/Kcon... PS3, Line 68: Handler
handler
Done