[coreboot-gerrit] [S] Change in coreboot[master]: nb/intel/i945/raminit: Use 'size_t' for banksize[]

[Martin L Roth (Code Review)]

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68213 )

Change subject: nb/intel/i945/raminit: Use 'size_t' for banksize[]
......................................................................

nb/intel/i945/raminit: Use 'size_t' for banksize[]

Change-Id: I4fb845bb4145d47aea39d7e5493d854d00e289aa
Signed-off-by: Elyes Haouas 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68213
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/northbridge/intel/i945/raminit.c
M src/northbridge/intel/i945/raminit.h
2 files changed, 18 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index c9b0837..7b8c84d 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -426,11 +426,12 @@
    		die("DDR-II rank size smaller than 128MB is not supported.\n");

sysinfo->banksize[i * 2] = dimm_info.ranksize_mb / 32;
-		printk(BIOS_DEBUG, "DIMM %d side 0 = %d MB\n", i, sysinfo->banksize[i * 2] * 32);
+		printk(BIOS_DEBUG, "DIMM %d side 0 = %zu MB\n", i,
+			sysinfo->banksize[i * 2] * 32);
    	if (dimm_info.ranks == 2) {
    		sysinfo->banksize[(i * 2) + 1] =
    			dimm_info.ranksize_mb / 32;
-			printk(BIOS_DEBUG, "DIMM %d side 1 = %d MB\n",
+			printk(BIOS_DEBUG, "DIMM %d side 1 = %zu MB\n",
    			i, sysinfo->banksize[(i * 2) + 1] * 32);
    	}

@@ -1142,7 +1143,7 @@
 static int sdram_program_row_boundaries(struct sys_info *sysinfo)
 {
    int i;
-	int cum0, cum1, tolud, tom, pci_mmio_size;
+	size_t cum0, cum1, tolud, tom, pci_mmio_size;
    const struct device *dev;
    const struct northbridge_intel_i945_config *cfg = NULL;

diff --git a/src/northbridge/intel/i945/raminit.h b/src/northbridge/intel/i945/raminit.h
index d69110e..efaedf4 100644
--- a/src/northbridge/intel/i945/raminit.h
+++ b/src/northbridge/intel/i945/raminit.h
@@ -49,7 +49,7 @@
 #define SYSINFO_DIMM_NOT_POPULATED	0x04

u8 banks[2 * DIMM_SOCKETS];
-	u8 banksize[2 * 2 * DIMM_SOCKETS];
+	size_t banksize[2 * 2 * DIMM_SOCKETS];
    const u8 *spd_addresses;

} __packed;