Attention is currently required from: Felix Held, Maxim, Paul Menzel.
Angel Pons has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83196?usp=email )
Change subject: util/superiotool: Add extra selectors support ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File util/superiotool/superiotool.c:
https://review.coreboot.org/c/coreboot/+/83196/comment/ffc82727_30bc1e92?usp... : PS5, Line 87: static void set_extra_selector(uint16_t port, const struct extra_selector *esel) : { : if (esel->idx == 0) /* entry without extra selector */ : return; : : uint8_t reg_val = regval(port, esel->idx); : reg_val &= ~esel->mask; : reg_val |= esel->val; : regwrite(port, esel->idx, reg_val); : : reg_val = regval(port, esel->idx) & esel->mask; : : printf(" -- ESEL[%02xh] 0x%02x", esel->idx, reg_val); : if (esel->name != NULL) : printf(" (%s)", esel->name); : printf(" --"); : : if (verbose) : printf(" config: idx=%02xh, mask=%02xh, val=%02xh state --", esel->idx, esel->mask, : esel->val); : } : What does this look like in the superiotool output? I don't see any newlines so it seems like it would print a very long line.