Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 10:
(18 comments)
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 83: PAD_CFG_GPO_GPIO_DRIVER(GPP_B0, 1, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 86: PAD_CFG_GPO_GPIO_DRIVER(GPP_B1, 1, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 116: PAD_CFG_GPO_GPIO_DRIVER(GPP_B11, 0, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 143: PAD_CFG_GPO_GPIO_DRIVER(GPP_B20, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 166: PAD_CFG_GPO_GPIO_DRIVER(GPP_C5, 1, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 224: PAD_CFG_GPO_GPIO_DRIVER(GPP_D1, 1, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 233: PAD_CFG_GPO_GPIO_DRIVER(GPP_D4, 0, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 275: PAD_CFG_GPO_GPIO_DRIVER(GPP_D18, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 278: PAD_CFG_GPO_GPIO_DRIVER(GPP_D19, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 284: PAD_CFG_GPO_GPIO_DRIVER(GPP_D21, 0, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 350: PAD_CFG_GPO_GPIO_DRIVER(GPP_F6, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 353: PAD_CFG_GPO_GPIO_DRIVER(GPP_F7, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 356: PAD_CFG_GPO_GPIO_DRIVER(GPP_F8, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 401: PAD_CFG_GPO_GPIO_DRIVER(GPP_F23, 0, RSMRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 476: PAD_CFG_GPO_GPIO_DRIVER(GPP_H0, 1, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 482: PAD_CFG_GPO_GPIO_DRIVER(GPP_H2, 1, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 487: /* GPP_H4 - GPIO */ : PAD_CFG_GPI_INT(GPP_H4, NONE, PLTRST, OFF), : : /* GPP_H5 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H5, 1, PLTRST, NONE), : : /* GPP_H6 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H6, 1, PLTRST, NONE), : : /* GPP_H7 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H7, 1, PLTRST, NONE), : : /* GPP_H8 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H8, 1, PLTRST, NONE), : : /* GPP_H9 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H9, 1, PLTRST, NONE), : same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 532: GPP_H19 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H19, 1, PLTRST, NONE), : : /* GPP_H20 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H20, 1, PLTRST, NONE), : : /* GPP_H21 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H21, 1, PLTRST, NONE), : : /* GPP_H22 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H22, 1, PLTRST, NONE), : : /* GPP_H23 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H23, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics