Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48089 )
Change subject: intel/common/block/gpio: only reset configured SMI instead of all
......................................................................
Patch Set 10: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/48089/10/src/soc/intel/common/block...
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/48089/10/src/soc/intel/common/block...
PS10, Line 169: en_reg = GPI_SMI_EN_OFFSET(comm, group);
nit: This didn't really have to move up from line 175.
https://review.coreboot.org/c/coreboot/+/48089/10/src/soc/intel/common/block...
PS10, Line 170: en_value
nit: Should this be just value since it is used for both sts_reg and en_reg?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48089
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecf789d3009011381835959cb1c166f703f1c0cc
Gerrit-Change-Number: 48089
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 18:12:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment