Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36180 )
Change subject: mb/ocp/monolake: Configure IPMI BMC FRB2 watchdog timer via VPD variables ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36180/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36180/3//COMMIT_MSG@14 PS3, Line 14: error
How does that work? If you reset the training will fail again on the same place.
The general idea is that the FRB2 timer should be started as early as possible in order to have a wider coverage during booting up. Right now because we can't send/receive IPMI before ramstage, so if the booting got stuck at romstage it can't be reset by IPMI watchdog timer and will be blocked indefinitely. As for FSP-M if after watchdog reset it still got blocked at memory training then yes it will reset again.
https://review.coreboot.org/c/coreboot/+/36180/3/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/mainboard.c:
https://review.coreboot.org/c/coreboot/+/36180/3/src/mainboard/ocp/monolake/... PS3, Line 62: 1
Use enum instead
Done