Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76871?usp=email )
Change subject: mb/system76/cml-u: Fix inclusion of romstage.c ......................................................................
mb/system76/cml-u: Fix inclusion of romstage.c
When lemp9 was converted to a variant in CB:64528, the Makefile was not updated to handle the variant-specific `romstage.c`. This, as would be expected, caused memory init errors and broke boot on CML-U boards.
Tested lemp9 boots to payload again.
Fixes: 5b7b04c938f2 ("mb/system76/cml-u: Convert lemp9 to a variant") Change-Id: Ibc11d69a1662df653e6553421d67a9cd1b1d03e2 Signed-off-by: Tim Crawford tcrawford@system76.com --- M src/mainboard/system76/cml-u/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/76871/1
diff --git a/src/mainboard/system76/cml-u/Makefile.inc b/src/mainboard/system76/cml-u/Makefile.inc index 5276308..51ad543 100644 --- a/src/mainboard/system76/cml-u/Makefile.inc +++ b/src/mainboard/system76/cml-u/Makefile.inc @@ -3,6 +3,8 @@ bootblock-y += bootblock.c bootblock-y += gpio_early.c
+romstage-y += variants/$(VARIANT_DIR)/romstage.c + ramstage-y += ramstage.c ramstage-y += variants/$(VARIANT_DIR)/gpio.c ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c