Hello Marco Chen, Jett Rink, Keith Short, Justin TerAvest, Shelley Chen, build bot (Jenkins), Scott Collyer, Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36068
to look at the new patch set (#7).
Change subject: hatch: refactor GPIOs into baseboard, allow empty SPDs ......................................................................
hatch: refactor GPIOs into baseboard, allow empty SPDs
Each variant had to define the GPIOs for memory configuration, even if they were the same as the baseboard. Moved the definititions into baseboard/gpio.h so that if the variant doesn't change the pins, it doesn't need to do anything.
Each variant needed to define variant_early_gpio_table(), even if it didn't need to make any changes. Added a __weak version of the function into baseboard/gpio.c.
Certain upcoming Hatch variants will not use SPD files. Allow SPD_SOURCES in spd/Makefile.inc to be empty.
BUG=None BRANCH=None TEST=Build coreboot and see that it builds without error
Change-Id: Ie946cfd7c071824168faa38fd53bd338a5a451e1 Signed-off-by: Paul Fagerburg pfagerburg@chromium.org --- M src/mainboard/google/hatch/spd/Makefile.inc M src/mainboard/google/hatch/variants/baseboard/gpio.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h 3 files changed, 26 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/36068/7