Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34157 )
Change subject: soc/intel/cannonlake: Add device Ids for CFL Refresh support
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34157/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34157/8//COMMIT_MSG@7
PS8, Line 7: soc/intel/cannonlake: Add device Ids for CFL Refresh support
Some of the IDs date back to mid 2018, are you sure it's all CFL "Refresh"?
which specific IDs?
https://review.coreboot.org/c/coreboot/+/34157/8/src/soc/intel/cannonlake/bo...
File src/soc/intel/cannonlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/34157/8/src/soc/intel/cannonlake/bo...
PS8, Line 109: 2
This is the same 2 as in GT2, why specify it two times?
what do you mean it is the same? both have different DIDs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34157
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I343b11ea8d9c33eb189d7478511a473b145f4ab4
Gerrit-Change-Number: 34157
Gerrit-PatchSet: 8
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Boon Tiong Teo
boon.tiong.teo@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Comment-Date: Thu, 11 Jul 2019 09:07:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment