Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75403?usp=email )
Change subject: mb/google/nissa/var/pujjo: Set GPIO of WWAN_SAR_DETECT to NC ......................................................................
mb/google/nissa/var/pujjo: Set GPIO of WWAN_SAR_DETECT to NC
Pujjo does not support GPIO based D-SAR, so set GPP_D15 and GPP_H23 to NC.
BUG=b:275264095 TEST=boot on pujjo and no impact WWAN dynamic SAR function
Signed-off-by: Leo Chou leo.chou@lcfc.corp-partner.google.com Change-Id: I4fe40b32a572a8d914e01e5cd7927766ccf17c02 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75403 Reviewed-by: Derek Huang derekhuang@google.com Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/variants/pujjo/gpio.c 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: Derek Huang: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/pujjo/gpio.c b/src/mainboard/google/brya/variants/pujjo/gpio.c index fd3dca5..e8e4fbe 100644 --- a/src/mainboard/google/brya/variants/pujjo/gpio.c +++ b/src/mainboard/google/brya/variants/pujjo/gpio.c @@ -26,8 +26,8 @@ PAD_CFG_GPI_APIC(GPP_H19, NONE, PLTRST, LEVEL, NONE), /* H22 : WCAM_MCLK_R ==> NC */ PAD_NC(GPP_H22, NONE), - /* H23 : WWAN_SAR_DETECT_ODL */ - PAD_CFG_GPO(GPP_H23, 1, DEEP), + /* H23 : WWAN_SAR_DETECT_ODL ==> NC */ + PAD_NC_LOCK(GPP_H23, NONE, LOCK_CONFIG), };
/* Pad configuration in ramstage for Pujjoteen5 */ @@ -42,8 +42,8 @@ PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* D6 : SRCCLKREQ1# ==> WWAN_EN */ PAD_CFG_GPO_LOCK(GPP_D6, 1, LOCK_CONFIG), - /* D15 : EN_PP2800_WCAM_X ==> WWAN_SAR_DETECT_2_ODL */ - PAD_CFG_GPO(GPP_D15, 1, DEEP), + /* D15 : EN_PP2800_WCAM_X ==> NC */ + PAD_NC_LOCK(GPP_D15, NONE, LOCK_CONFIG), /* D16 : EN_PP1800_PP1200_WCAM_X ==> NC */ PAD_NC_LOCK(GPP_D16, NONE, LOCK_CONFIG), /* D17 : NC ==> SD_WAKE_N */ @@ -56,8 +56,8 @@ PAD_CFG_GPO(GPP_H21, 0, DEEP), /* H22 : WCAM_MCLK_R ==> NC */ PAD_NC(GPP_H22, NONE), - /* H23 : WWAN_SAR_DETECT_ODL */ - PAD_CFG_GPO(GPP_H23, 1, DEEP), + /* H23 : WWAN_SAR_DETECT_ODL ==> NC */ + PAD_NC_LOCK(GPP_H23, NONE, LOCK_CONFIG), };
/* Early pad configuration in bootblock */