Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45097 )
Change subject: soc/amd/picasso: Add emmc_config->preset_drive_strength
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45097/1/src/soc/amd/picasso/chip.h
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/45097/1/src/soc/amd/picasso/chip.h@...
PS1, Line 159: MMCCFG
: * HS400 preset
nit I wouldn't name any undocumented registers.
How about:
The drive strength is also set in the HS400 preset register.
?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45097
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44951cacb1e9d788016a70283cf9688bf88a09f4
Gerrit-Change-Number: 45097
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Sep 2020 15:26:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment