Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43441 )
Change subject: src/soc/intel/common/hda: support audio jack for Boten ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@7 PS1, Line 7: src/ Please remove `src/` from the prefix.
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@7 PS1, Line 7: support audio jack for Boten Maybe your text from the commit message body:
Add HDA ID for Jasper Lake
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@9 PS1, Line 9: Add HDA ID for Jasperlake Maybe:
Currently, audio is not working on Boten, caused by the corebood HDA driver not being run as the Jasper Lake PCI ID is missing. So, add the Jasper Lake ID.
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@13 PS1, Line 13: TEST=Add PCI ID to hda.c for boten Maybe:
Connect speaker to audio jack, and verify sound is played.