Attention is currently required from: Arthur Heymans, Julius Werner, Maximilian Brune, Nico Huber, Philipp Hug, Ron Minnich.
Angel Pons has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/81910?usp=email )
Change subject: commonlib/bsd/lz4_wrapper.c: Fix misaligned access
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/commonlib/bsd/lz4_wrapper.c:
https://review.coreboot.org/c/coreboot/+/81910/comment/748ac5cc_339ff531?usp... :
PS5, Line 14: static uint16_t LZ4_readLE16(const void *src)
: {
: return *((const uint8_t *)src + 1) << 8
: | *(const uint8_t *)src;
: }
:
: static uint32_t LZ4_readLE32(const void *src)
: {
: return *((const uint8_t *)src + 3) << 24
: | *((const uint8_t *)src + 2) << 16
: | *((const uint8_t *)src + 1) << 8
: | *(const uint8_t *)src;
: }
+1 to Angel's suggested edit
Given Nico's tests, I don't think there's any need to overcomplicate this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81910?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id165829bfd35be2bce2bbb019c208a304f627add
Gerrit-Change-Number: 81910
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Sat, 22 Jun 2024 00:03:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz