Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35294 )
Change subject: superio/common: fix regression in ssdt
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35294/2/src/superio/common/generic....
File src/superio/common/generic.c:
https://review.coreboot.org/c/coreboot/+/35294/2/src/superio/common/generic....
PS2, Line 116: level
even though the spec call this level; i'd rather call this number, since it's effectively the irq number
https://review.coreboot.org/c/coreboot/+/35294/2/src/superio/common/generic....
PS2, Line 122: level
same here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f3307d0992fcf5ad192f412c2bd15d02572a6b0
Gerrit-Change-Number: 35294
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 10 Sep 2019 11:04:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment