Attention is currently required from: Frank Chu.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61675 )
Change subject: mb/google/volteer/var/drobit: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61675/comment/bdbe7063_30240b09
PS4, Line 9: ALC5682-VD/ALC5682I-VS load different kernel driver by different _HID
: name.
Should be this CL for ChromeOS 5.4 kernel, https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3...
unless I'm missing something, that CL just added 'RTL5682' as an alternate _HID, there's not any handling to distinguish between that and '10EC5682', and I didn't see any in subsequent commits either (in mainline or SOF).
Don't mean to harp on this, just the _HID change breaks audio on my Drobit device running mainline Linux, even with the latest stable kernel (5.16.7)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c1c9819af1e0bc2278dadeffb6b19c3f9068f30
Gerrit-Change-Number: 61675
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 15 Feb 2022 14:03:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment