Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42976 )
Change subject: /mb/ocp/deltalake: disable MAINBOARD_POWER_FAILURE_STATE ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42976/4/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/42976/4/src/mainboard/ocp/deltalake... PS4, Line 16: config MAINBOARD_POWER_FAILURE_STATE This is supposed to be controlled by the user choice in the "Mainboard" menu. If you override it here, the user may not get what they selected.
The default for the user choice is controlled with POWER_STATE_DEFAULT_ ON_AFTER_FAILURE. Currently it's selected by common Intel code, which has to change if you want to override it.
I guess the following could work:
* In `soc/intel/common/block/pmc/Kconfig` remove the `select` and add
config POWER_STATE_DEFAULT_ON_AFTER_FAILURE default y
* And here
config POWER_STATE_DEFAULT_ON_AFTER_FAILURE default n