Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35666 )
Change subject: mb/google/drallion: Adjust GPD3 pin termination
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35666/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35666/7//COMMIT_MSG@10
PS7, Line 10: EDS vol1 section 17-1.
Can you please email me the doc# and version? I cannot find this recommendation in the EDS.
https://review.coreboot.org/c/coreboot/+/35666/7//COMMIT_MSG@11
PS7, Line 11: stay floating
Is this because there is no PU on the board?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35666
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd1befeb14a251b7c0542ca1f99049d07b28fb98
Gerrit-Change-Number: 35666
Gerrit-PatchSet: 7
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Mathew King
mathewk@chromium.org
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Comment-Date: Mon, 30 Sep 2019 05:35:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment