Attention is currently required from: Hung-Te Lin, Xi Chen, Paul Menzel, Xixi Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61334 )
Change subject: soc/mediatek: Pass dram info to cbmem ......................................................................
Patch Set 21:
(9 comments)
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/61334/comment/e9a2ca56_77251de2 PS21, Line 29: curr_dram_info Please remove this.
https://review.coreboot.org/c/coreboot/+/61334/comment/0c403337_d9e96d36 PS21, Line 108: p channel
https://review.coreboot.org/c/coreboot/+/61334/comment/18b0236b_0d1a9a65 PS21, Line 110: MEM_CHIP_LPDDR4X Do we use LPDDR4X for all MTK platforms?
https://review.coreboot.org/c/coreboot/+/61334/comment/a4ae491a_c4f75970 PS21, Line 117: total_density / mc->num_channels What is this for?
https://review.coreboot.org/c/coreboot/+/61334/comment/1647b4bd_85359856 PS21, Line 129: void *mem_region_base struct mem_chip_info *mc;
https://review.coreboot.org/c/coreboot/+/61334/comment/32a56b6e_5254ed2d PS21, Line 131: Check if curr_ddr_info is NULL.
https://review.coreboot.org/c/coreboot/+/61334/comment/885dd169_444460b7 PS21, Line 132: curr_dram_info *mc
https://review.coreboot.org/c/coreboot/+/61334/comment/ad41f79b_0d259688 PS21, Line 134: ASSERT assert(mc);
https://review.coreboot.org/c/coreboot/+/61334/comment/098f4ac0_9099c444 PS21, Line 217: ddr_info 1. Why do we want to rename this? 2. The renaming seems unrelated to the cbmem thing.