Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45644 )
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification ......................................................................
mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification
Modify I2C3 setting to follow I2C specification(lower than 400kHz). Original setting: .rise_time_ns = 125 .fall_time_ns = 37
Change to: .rise_time_ns = 110 .fall_time_ns = 34
BUG=b:169207742 BRANCH=None TEST=emerge-zork coreboot chromeos-bootimage
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0f0b791c3e701ebf6b336a8cb259eeb74c46af5a Reviewed-on: https://review.coreboot.org/c/coreboot/+/45644 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Angel Pons: Looks good to me, approved Kane Chen: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb index d1c5507..8d94a97 100644 --- a/src/mainboard/google/zork/variants/woomax/overridetree.cb +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -60,8 +60,8 @@ # Enable I2C3 for H1 400kHz register "i2c[3]" = "{ .speed = I2C_SPEED_FAST, - .rise_time_ns = 125, /* 0 to 1.26v (1.8 * .7) */ - .fall_time_ns = 37, /* 1.26v to 0 */ + .rise_time_ns = 110, /* 0 to 1.26v (1.8 * .7) */ + .fall_time_ns = 34, /* 1.26v to 0 */ .early_init = true, }"