Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47983 )
Change subject: soc/common: Program SF Mask MSRs for eNEM ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/47983/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47983/5//COMMIT_MSG@12 PS5, Line 12: corresponding to available number of ways to 1b. It would be helpful to also capture some information about why _V1/_V2 are being dropped. I am thinking it would be good to split this change into 2 CLs: 1. Drop _V2 and rename _V1 2. Add support for CAR_HAS_SF_MASKS
It is easier to see what is changing and why.
https://review.coreboot.org/c/coreboot/+/47983/5//COMMIT_MSG@16 PS5, Line 16: =<Yet to run> Needs update. Was this change verified?
https://review.coreboot.org/c/coreboot/+/47983/5/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/47983/5/src/soc/intel/common/block/... PS5, Line 413: %ecx ecx was used to back up the number of ways in line 404. Moving eax to ecx is going to overwrite that backup.
https://review.coreboot.org/c/coreboot/+/47983/5/src/soc/intel/common/block/... PS5, Line 415: $ %
https://review.coreboot.org/c/coreboot/+/47983/5/src/soc/intel/common/block/... PS5, Line 427: IA32_CR_SF_QOS_MASK_2 with : * total number of LLC ways The recommendation in the document Shyam shared was to set this to all 0s.