Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48114 )
Change subject: mb/google/brya: Enable EC
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48114/3/src/mainboard/google/brya/v...
File src/mainboard/google/brya/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/48114/3/src/mainboard/google/brya/v...
PS3, Line 14: EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |\
Noted. […]
Sorry I misread this as wake events 😊 I think it's finally been clarified when we want to wake (and not) from A/C connect & disconnect events... I don't think that was always clear between programs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48114
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1305706134ca7cc58b8a9941231d1ee14f80949
Gerrit-Change-Number: 48114
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 20:36:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment