Attention is currently required from: Paul Menzel.
Vladimir Serbinenko has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/82737?usp=email )
Change subject: superio/ite/it8728f: Support setting power state after power failure ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82737/comment/2bbba2cb_f31164c1?usp... : PS1, Line 7: it8728f
superio/ite/it8728f
Done
https://review.coreboot.org/c/coreboot/+/82737/comment/bcec83fc_258ad704?usp... : PS1, Line 9: Tested on GA-H61M-S2PV
Maybe mention power_on_after_fail
Done
File src/superio/ite/it8728f/superio.c:
https://review.coreboot.org/c/coreboot/+/82737/comment/9f4bec1e_2c9346c2?usp... : PS1, Line 42: if (power_status == MAINBOARD_POWER_ON) : byte_f4 |= 0x20;
Please add {} around the branch, as at least one other branch uses them.
Done