Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31421 )
Change subject: SMBIOS: Update BMC Interface Type field ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31421/2/src/include/smbios.h File src/include/smbios.h:
https://review.coreboot.org/#/c/31421/2/src/include/smbios.h@484 PS2, Line 484: SMBIOS_BMC_INTERFACE_KCS = 0x01, : SMBIOS_BMC_INTERFACE_SMIC = 0x02, : SMBIOS_BMC_INTERFACE_BLOCK = 0x03, : SMBIOS_BMC_INTERFACE_SMBUS = 0x04, :
The equates are not needed, this is an enum. […]
Binaries are fine without the equates here, but only because the particular enumeration here does not have any gaps.
You can notice many of the other enums in this file actually have these equates even for cases without gaps. Like smbios_memory_bus_width and smbios_memory_array_ecc. That's because this has to meet external specification and source is more readable with than without them.