[coreboot-gerrit] Change in coreboot[master]: nb/intel/snb: Reduce scope of functions

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63701 )

Change subject: nb/intel/snb: Reduce scope of functions
......................................................................

nb/intel/snb: Reduce scope of functions

Change-Id: Idefbe15c5f7c7169d9b60079b90cd02affb261ca
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63701
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Felix Singer 
Reviewed-by: Angel Pons 
---
M src/northbridge/intel/sandybridge/raminit.h
M src/northbridge/intel/sandybridge/raminit_mrc.c
2 files changed, 5 insertions(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Felix Singer: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/northbridge/intel/sandybridge/raminit.h b/src/northbridge/intel/sandybridge/raminit.h
index dd4e572..fa9fa98 100644
--- a/src/northbridge/intel/sandybridge/raminit.h
+++ b/src/northbridge/intel/sandybridge/raminit.h
@@ -9,10 +9,6 @@
 #define BOOT_PATH_RESET		1
 #define BOOT_PATH_RESUME	2

-void sdram_initialize(struct pei_data *pei_data);
-void save_mrc_data(struct pei_data *pei_data);
 void mainboard_fill_pei_data(struct pei_data *pei_data);
-int fixup_sandybridge_errata(void);
-void setup_sdram_meminfo(struct pei_data *pei_data);

#endif /* RAMINIT_H */
diff --git a/src/northbridge/intel/sandybridge/raminit_mrc.c b/src/northbridge/intel/sandybridge/raminit_mrc.c
index fbb2b6e..0bc33b6 100644
--- a/src/northbridge/intel/sandybridge/raminit_mrc.c
+++ b/src/northbridge/intel/sandybridge/raminit_mrc.c
@@ -49,7 +49,7 @@

#define MRC_CACHE_VERSION 0

-void save_mrc_data(struct pei_data *pei_data)
+static void save_mrc_data(struct pei_data *pei_data)
 {
    u16 c1, c2, checksum;

@@ -127,7 +127,7 @@
  *
  * @param pei_data: configuration data for UEFI PEI reference code
  */
-void sdram_initialize(struct pei_data *pei_data)
+static void sdram_initialize(struct pei_data *pei_data)
 {
    int (*entry)(struct pei_data *pei_data) __attribute__((regparm(1)));

@@ -320,6 +320,8 @@
    RCBA32(FD) |= PCH_DISABLE_P2P;
 }

+static void setup_sdram_meminfo(struct pei_data *pei_data);
+
 void perform_raminit(int s3resume)
 {
    struct pei_data pei_data;
@@ -390,7 +392,7 @@
    setup_sdram_meminfo(&pei_data);
 }

-void setup_sdram_meminfo(struct pei_data *pei_data)
+static void setup_sdram_meminfo(struct pei_data *pei_data)
 {
    u32 addr_decoder_common, addr_decode_ch[2];
    struct memory_info *mem_info;