Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35481 )
Change subject: soc/mediatek/mt8183: Handle memory test failure
......................................................................
Patch Set 50:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35481/50//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35481/50//COMMIT_MSG@16
PS50, Line 16: draining out of battery
Doesn’t the hang also drain the battery? […]
the reboot process would consume more power consumption, and may cause I/O on more peripherals (for example SPI), especially causing TPM issues.
there's currently no standard way of handling DRAM initialization error on chromebooks, but I think we should just hang(halt) or poweroff. Let's try hang for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35481
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e1d4f5bc7b45f45a8bfef74e86ec0ff6a556af4
Gerrit-Change-Number: 35481
Gerrit-PatchSet: 50
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 16 Oct 2019 01:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment