[coreboot-gerrit] [L] Change in coreboot[main]: drivers/ipmi: add Block Transfer (BT) interface

[Paul Menzel (Code Review)]

Attention is currently required from: Christian Walter, Jonathan Zhang, Krystian Hebel, Martin L Roth, Martin Roth, Michał Żygowski, Sergii Dmytruk.

Paul Menzel has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/67057?usp=email )

Change subject: drivers/ipmi: add Block Transfer (BT) interface
......................................................................

Patch Set 33:

(7 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/67057/comment/f7f63dcf_e4da8dac?usp... :
PS33, Line 14: 
How did you test this? Can it be tested with QEMU? Maybe mention the datasheet name?

File Documentation/drivers/index.md:

https://review.coreboot.org/c/coreboot/+/67057/comment/a5093476_59576fd7?usp... :
PS33, Line 15: BT
Include Block Transfer?

File Documentation/drivers/ipmi_bt.md:

https://review.coreboot.org/c/coreboot/+/67057/comment/6948a3f8_e71444a6?usp... :
PS33, Line 14: ```
             :  chip drivers/ipmi
             :    device pnp e4.0 on end        # IPMI BT
             :  end
             : ```
I’d prefer intending by four spaces. But feel free to mark as resolved.

https://review.coreboot.org/c/coreboot/+/67057/comment/3693746d_58c865d4?usp... :
PS33, Line 22: The following registers can be set:
Where can they be set?

File src/drivers/ipmi/Kconfig:

https://review.coreboot.org/c/coreboot/+/67057/comment/d237785a_0c27c694?usp... :
PS33, Line 85: for implementation
*an* implementation?

or
> … for implementations using polling.

File src/drivers/ipmi/ipmi_bt_ops.c:

https://review.coreboot.org/c/coreboot/+/67057/comment/1d91adfd_d628ad3a?usp... :
PS33, Line 103: 		printk(BIOS_ERR, "%s: Unsupported device type\n",
Print both values?

https://review.coreboot.org/c/coreboot/+/67057/comment/2351f63b_23c414b8?usp... :
PS33, Line 106: 		printk(BIOS_ERR, "%s: Base address needs to be aligned to 4\n",
Print the address?