Attention is currently required from: Arthur Heymans, David Milosevic, Julius Werner.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78284?usp=email )
Change subject: arch/arm64: Support calling a trusted monitor
......................................................................
Patch Set 15:
(1 comment)
File src/arch/arm64/include/armv8/arch/smc.h:
https://review.coreboot.org/c/coreboot/+/78284/comment/4ebc36e1_5b8458c0 :
PS13, Line 8: static inline u
Sorry, this one can't be static inline. […]
Oh, I see. I thought that I could forward the declaration on to the assembly, and it would inline that into the caller. Although maybe that doesn't make sense after all, since the assembly function is its own symbol. My mistake.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78284?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I158db0b971aba722b3995d52162146aa406d1644
Gerrit-Change-Number: 78284
Gerrit-PatchSet: 15
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Fri, 19 Apr 2024 21:35:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment