Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31993 )
Change subject: gale: add dev switch back as physical presence GPIO
......................................................................
Patch Set 2:
Given that this data is shared across the boundary from coreboot to the payload, is GPIO_MAX_NAME_LENGTH something that we can change?
Alternatively, any clever abbreviations for "physical presence"?
Let's avoid changing the record format unless we really have to. How about just "presence"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31993
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic144f839b7f9933d573db8f84c4bf5905eea96f6
Gerrit-Change-Number: 31993
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 21 Mar 2019 22:32:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment